Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): Don't crash dev mode when rebuild fails #565

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Mar 24, 2024

This closes #553.

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 9d4e59d
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6600525d92a8220008636acd
😎 Deploy Preview https://deploy-preview-565--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 changed the title fix(dev): Don't crash dev mode on syntax error fix(dev): Don't crash dev mode when rebuild fails Mar 24, 2024
@aklinker1 aklinker1 marked this pull request as ready for review March 24, 2024 16:19
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 86.31%. Comparing base (36b399d) to head (9d4e59d).

Files Patch % Lines
src/core/create-server.ts 9.37% 29 Missing ⚠️
src/core/utils/building/build-entrypoints.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   86.51%   86.31%   -0.20%     
==========================================
  Files         111      111              
  Lines        8898     8903       +5     
  Branches      881      879       -2     
==========================================
- Hits         7698     7685      -13     
- Misses       1186     1204      +18     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit 829b371 into main Mar 24, 2024
17 checks passed
@aklinker1 aklinker1 deleted the catch-errors-in-dev-mode branch March 24, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graceful error handling
1 participant