-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support returning values from scripts executed with the scripting API #624
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
==========================================
- Coverage 86.66% 86.49% -0.17%
==========================================
Files 112 112
Lines 9061 9111 +50
Branches 908 910 +2
==========================================
+ Hits 7853 7881 +28
- Misses 1194 1216 +22
Partials 14 14 ☔ View full report in Codecov by Sentry. |
package.json
Outdated
"version": "0.17.12", | ||
"version": "0.17.13-alpha1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert before merging
Waiting for validation from discord to make sure this works for the person who reported it... https://discord.com/channels/1212416027611365476/1229813661821046794/1229813661821046794 |
5e2aaaf
to
d91277f
Compare
Gonna go ahead and merge this, original user hasn't responded for a week or so, and there's already too many PRs in draft right now... |
Released in |
This closes #622.
Adds support for returning values from both content scripts (likely with
registration: 'runtime'
, but not necessarily) and unlisted scripts.Just return a value from the script's main function and the background will get the value, even if it's an async function.