Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Automatically move host_permissions to permissions for MV2 #626

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

aklinker1
Copy link
Collaborator

This closes #602

@aklinker1 aklinker1 added the bug Something isn't working label Apr 20, 2024
@aklinker1 aklinker1 changed the title feat: Automatically move host_permissions to permissions for MV2 fix: Automatically move host_permissions to permissions for MV2 Apr 20, 2024
Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 1fa39fa
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/66233039d37c6600086447fb
😎 Deploy Preview https://deploy-preview-626--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (e47519f) to head (1fa39fa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   86.76%   86.70%   -0.06%     
==========================================
  Files         112      112              
  Lines        9050     9062      +12     
  Branches      908      911       +3     
==========================================
+ Hits         7852     7857       +5     
- Misses       1184     1191       +7     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 changed the title fix: Automatically move host_permissions to permissions for MV2 fix!: Automatically move host_permissions to permissions for MV2 Apr 20, 2024
@aklinker1 aklinker1 marked this pull request as ready for review April 20, 2024 03:04
@aklinker1 aklinker1 merged commit efd5c40 into main Apr 20, 2024
15 checks passed
@aklinker1 aklinker1 deleted the host-permissions-to-permissions-mv2 branch April 20, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev mode for firefox mv2 failed to copy host_permissions to permissions
1 participant