Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

升级到 umi3 #2

Merged
merged 5 commits into from
Apr 8, 2021
Merged

升级到 umi3 #2

merged 5 commits into from
Apr 8, 2021

Conversation

phobal
Copy link
Contributor

@phobal phobal commented Apr 8, 2021

目前 umi-plugin-theme-switch 版本 是基于 umi2 插件机制开发的,umi3 有很多 break change, 所以没办法直接在 umi3 中使用该插件。

// api.modifyConfig(newOpts => {
// opts = Object.assign({}, defaultConfig, newOpts);
// api.restartServer();
// });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要在插件内部去监听配置的变化,umi 内部做了处理

Copy link
Owner

@wxul wxul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxul wxul merged commit 0a527e9 into wxul:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants