Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spaces around tokens in the require statement for :require_rewrite #13

Merged
merged 1 commit into from Jan 22, 2012

Conversation

raghurajah
Copy link
Contributor

Some users have syntactically valid spaces (please don't ask why, I don't know) around the require statement. Like,

require    ( 'octopus')

The require_rewrite was skipping them. This trivial change basically tests for spaces around the open parentheses.

@dudleyf
Copy link
Collaborator

dudleyf commented Jan 22, 2012

:rewrite_requires is a hack. It also doesn't support require statements anywhere except at the beginning of a line. Hopefully a future version of minispade will pass require into the module function, making it unnecessary to preprocess the source. You get points for including a test, though :)

dudleyf pushed a commit that referenced this pull request Jan 22, 2012
Support spaces around tokens in the require statement for :require_rewrite
@dudleyf dudleyf merged commit 32428ba into wycats:master Jan 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants