Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of APR for secure randomness cross platform #9

Closed
wants to merge 3 commits into from

Conversation

dirkx
Copy link

@dirkx dirkx commented Dec 21, 2021

Make use of APR for secure randomness cross platform, force the length of the nonce to be 144 bits; even if the struct is larger. Should fix #8

@wyattoday
Copy link
Member

wyattoday commented Dec 21, 2021

We're not going to use APR for RNG. It's very poorly documented.

Instead we use well documented PRNG for every platform (already in the code and tested on all major platforms).

@wyattoday wyattoday closed this Dec 21, 2021
@dirkx
Copy link
Author

dirkx commented Dec 21, 2021 via email

@wyattoday
Copy link
Member

wyattoday commented Dec 21, 2021

On Windows: it's cryptographically secure (see docs).

On macOS: it's cryptographically secure (see docs).

On Linux with a modern kernel: it's cryptographically secure (see docs).

Other unix variants: it depends on implementation details, but they tend to follow Linux's lead and be cryptographically secure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generation of randomness is not very secure
2 participants