Cythonize (de)serialization methods and enable errors customization #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closures have been converted into classes with one method. They have been regrouped in modules called methods.py. Only methods modules are cythonized. Cythonization is made by generating a pyx file from the Python file. This approach doesn't require much adaptation to the Python code. Also, it allows optimizations like dynamic dispatch conversion to switch (Python code would have been dirty to with a lot of if-chains). As constraints validation has been completely refactored to be cythonized too, error customization has been added at the same time as it was simpler.
|
Performances are greatly improved. Pydantic benchmark shows about x2.7 for serialization and x1.7 for deserialization. |
This was
linked to
issues
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closures have been converted into classes with one method. They have been regrouped in modules called methods.py. Only methods modules are cythonized.
Cythonization is made by generating a pyx file from the Python file. This approach doesn't require much adaptation to the Python code. Also, it allows optimizations like dynamic dispatch conversion to switch (Python code would have been dirty to with a lot of if-chains).
As constraints validation has been completely refactored to be cythonized too, error customization has been added at the same time as it was simpler.