Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore compilation failure at build #247

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Ignore compilation failure at build #247

merged 1 commit into from
Nov 11, 2021

Conversation

wyfo
Copy link
Owner

@wyfo wyfo commented Nov 11, 2021 •
edited

Fixes #243

@wyfo wyfo self-assigned this Nov 11, 2021
@wyfo wyfo added this to the v0.17 milestone Nov 11, 2021
@wyfo wyfo merged commit af3efb3 into master Nov 11, 2021
@wyfo wyfo deleted the ignore_compilation_failure branch November 11, 2021 22:32
@thomascobb
Copy link
Contributor

I think you also need to declare that this cmdclass should be used like here:
https://github.com/tornadoweb/tornado/blob/master/setup.py#L137

@wyfo
Copy link
Owner Author

wyfo commented Nov 12, 2021

And you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wyfo wyfo

Labels
None yet
Projects
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.

Make build compilation optional
2 participants
@wyfo @thomascobb