Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when missing type_name #250

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Improve error message when missing type_name #250

merged 2 commits into from
Nov 18, 2021

Conversation

thomascobb
Copy link
Contributor

Refs #248

@wyfo
Copy link
Owner

wyfo commented Nov 18, 2021

As you can see in the failure details, there is an assertion in tests/test_refs.py:123 which check the message of the recursion error, in order to ensure that this is the expected TypeError. You should fix the test, but I think adding a wildcard at the end of the check pattern would be enough.

@wyfo wyfo merged commit c5a74c8 into wyfo:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants