Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location to serialization type check errors #298

Merged
merged 3 commits into from
Dec 30, 2021
Merged

Conversation

wyfo
Copy link
Owner

@wyfo wyfo commented Dec 29, 2021

Fixes #261

@wyfo
Copy link
Owner Author

wyfo commented Dec 29, 2021

This implementation has a (significant?) impact on performance (5% slower) …

@wyfo wyfo changed the title Add path to serialization type check errors Add location to serialization type check errors Dec 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #298 (559eccb) into master (b68fa0b) will decrease coverage by 0.10%.
The diff coverage is 78.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   85.55%   85.44%   -0.11%     
==========================================
  Files          65       66       +1     
  Lines        5654     5675      +21     
  Branches     1167     1170       +3     
==========================================
+ Hits         4837     4849      +12     
- Misses        598      607       +9     
  Partials      219      219              
Impacted Files Coverage Δ
apischema/serialization/methods.py 86.09% <77.61%> (-2.41%) ⬇️
apischema/serialization/errors.py 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15683c0...559eccb. Read the comment docs.

@wyfo wyfo merged commit 33410a9 into master Dec 30, 2021
@wyfo wyfo deleted the type_check_error branch December 30, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add location to serialization errors
2 participants