Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenAPI discriminator #301

Merged
merged 4 commits into from
Dec 30, 2021
Merged

Support OpenAPI discriminator #301

merged 4 commits into from
Dec 30, 2021

Conversation

wyfo
Copy link
Owner

@wyfo wyfo commented Dec 30, 2021

Closes #220

@codecov-commenter
Copy link

Codecov Report

Merging #301 (5f6a7e1) into master (4b50187) will increase coverage by 0.56%.
The diff coverage is 93.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   85.44%   86.00%   +0.56%     
==========================================
  Files          66       67       +1     
  Lines        5675     5888     +213     
  Branches     1170     1225      +55     
==========================================
+ Hits         4849     5064     +215     
+ Misses        607      602       -5     
- Partials      219      222       +3     
Impacted Files Coverage Δ
apischema/json_schema/types.py 92.68% <ø> (ø)
apischema/deserialization/methods.py 84.80% <72.00%> (-0.31%) ⬇️
apischema/serialization/methods.py 87.63% <88.46%> (+1.54%) ⬆️
apischema/discriminators.py 95.23% <95.23%> (ø)
apischema/json_schema/schema.py 85.59% <95.23%> (+1.02%) ⬆️
apischema/serialization/__init__.py 84.55% <97.05%> (+2.22%) ⬆️
apischema/__init__.py 84.21% <100.00%> (+0.42%) ⬆️
apischema/conversions/visitor.py 95.23% <100.00%> (+8.28%) ⬆️
apischema/deserialization/__init__.py 98.97% <100.00%> (+0.10%) ⬆️
apischema/json_schema/refs.py 89.58% <100.00%> (+1.34%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b50187...5f6a7e1. Read the comment docs.

@wyfo wyfo merged commit 42b03cf into master Dec 30, 2021
@wyfo wyfo deleted the discriminator2 branch December 30, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discriminated union
2 participants