Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support of typing.Any in GraphQL schema #317

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Fix support of typing.Any in GraphQL schema #317

merged 2 commits into from
Jan 10, 2022

Conversation

wyfo
Copy link
Owner

@wyfo wyfo commented Jan 7, 2022

Fix #316

@codecov-commenter
Copy link

Codecov Report

Merging #317 (87b141f) into master (36b1b95) will increase coverage by 0.05%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   86.00%   86.05%   +0.05%     
==========================================
  Files          67       67              
  Lines        5888     5888              
  Branches     1225     1224       -1     
==========================================
+ Hits         5064     5067       +3     
+ Misses        602      600       -2     
+ Partials      222      221       -1     
Impacted Files Coverage Δ
apischema/graphql/resolvers.py 84.96% <ø> (-0.20%) ⬇️
apischema/graphql/schema.py 86.87% <80.00%> (+0.80%) ⬆️
apischema/deserialization/methods.py 84.72% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a85337...87b141f. Read the comment docs.

@wyfo
Copy link
Owner Author

wyfo commented Jan 7, 2022

I've just realized that Any translation in GraphQL schema was implemented too quickly, and there was in fact a "bug", because it should be JSON and not JSON!. So I would like to fix that too in this PR.
@thomascobb Is this change an issue for you? I will wait your answer before merging, or merge it monday evening otherwise.

@thomascobb
Copy link
Contributor

That shouldn't be an issue, thanks

@wyfo wyfo merged commit baa6e63 into master Jan 10, 2022
@wyfo wyfo deleted the fix_graphql_any branch January 10, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL Any type return value no longer mapped to JSON in 0.17
3 participants