Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cast to builtin types in deserialization methods #348

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

wyfo
Copy link
Owner

@wyfo wyfo commented Feb 6, 2022

Cast was added in order allow Cython using optimized operations on
containers. However, quick benchmark showed that it was in fact
surprisingly slower for small lists.

Cast was added in order allow Cython using optimized operations on
containers. However, quick benchmark showed that it was in fact
surprisingly slower for small lists.
@codecov-commenter
Copy link

Codecov Report

Merging #348 (de0b76d) into master (8349491) will decrease coverage by 0.01%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
- Coverage   86.22%   86.20%   -0.02%     
==========================================
  Files          67       67              
  Lines        5886     5878       -8     
  Branches     1221     1221              
==========================================
- Hits         5075     5067       -8     
  Misses        593      593              
  Partials      218      218              
Impacted Files Coverage Δ
apischema/deserialization/methods.py 84.80% <84.61%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8957280...de0b76d. Read the comment docs.

@wyfo wyfo linked an issue Feb 6, 2022 that may be closed by this pull request
@wyfo wyfo merged commit 84dcab4 into master Feb 6, 2022
@wyfo wyfo deleted the remove_builtin_cast branch February 6, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression deserializing a subclassed source
2 participants