Fix UncheckedTuples not failing for wrong amount of arguments #513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently apischema fails to correctly serialize a correctly typed dataclass with a "conflicting" union.
E.g.
currently fails as the serialization doesn't fail on trying to serialize into the first tuple.
It can be fixed by setting
check_type=True
, but I am not sure if this is really a "type" check or just the union serialization behaving wrongly.For now we worked around it with check_type, but as your documentation says https://wyfo.github.io/apischema/0.18/de_serialization/#type-checking this has futher performance impacts, I would like to discuss if the tuple method shouldn't also be able to handle this conflicting union, as the typing in the dataclass itself seems correct