Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #590

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Add support for Python 3.12 #590

merged 3 commits into from
Oct 9, 2023

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Oct 8, 2023

  • Update cython version for compatibility with Python 3.12
  • Update cibuildwheel to build 3.12 by default
  • Add 3.12 to ci test matrix
  • Add classifier for 3.12
  • Add setuptools as cythonize requirement. distutils isn't shipped with Python anymore.
  • Update pytest to fix DeprecationWarnings
  • Update typing_extensions to fix a Python 3.12 test error

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 8, 2023

@wyfo Would be awesome if you could take a look at it. This currently blocks us from installing requirements which depend on apischema on Python 3.12.

I believe, after the PR is merge, the only thing left would be to increment the version and do a new release.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Merging #590 (8a971d5) into master (f1b6d59) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files          62       62           
  Lines        5677     5677           
  Branches     1240     1240           
=======================================
  Hits         4996     4996           
  Misses        470      470           
  Partials      211      211           

@wyfo
Copy link
Owner

wyfo commented Oct 9, 2023

Thank you a lot for the PR!
I will do a release tonight.

@cdce8p cdce8p mentioned this pull request Oct 9, 2023
32 tasks
@wyfo wyfo merged commit e4652c8 into wyfo:master Oct 9, 2023
10 checks passed
@cdce8p cdce8p deleted the python-312 branch October 9, 2023 21:47
@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 9, 2023

Thank you a lot for the PR!
I will do a release tonight.

Thanks @wyfo! Just saw the new release. Unfortunately it seems the version wasn't updated so building apischema from source still won't work with Python 3.12 😕 Would you mind doing a new release with an updated version?
https://github.com/wyfo/apischema/blob/v0.18.1/setup.py#L89

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 10, 2023

It works now! Thanks again 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants