This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Some more bugs when using XHTML #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated development.html to HTML5 (contenteditable needs that).
|
I also added corrections to examples and test cases. |
|
Hi Philipp, Thanks so much for this pull request, and I'm sorry it's taken me so long to get to it (9 months already!?). These changes look great. When addressing some other issues, its become pretty clear that the xhtml doctype is the cause of some strange issues with IE. My current plan is to move towards:
It looks like there are a few merge conflicts, but I'll get these resolved soon and hopefully get this merged in. Thanks |
|
Sounds good. I was already giving up. 😃 |
winhamwr
added a commit
that referenced
this pull request
Jan 24, 2013
|
Merged in as part of #383. Thanks! |
lehni
pushed a commit
to wemakeit/wymeditor
that referenced
this pull request
May 15, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last commit was just the tip of the iceberg: I found two other issues with XHTML strict mode and Firefox. The IE part is guessed, but probably not necessary. (Afaik IE doesn’t have an XHTML mode. Maybe someday. Probably not.)