This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Undoing back to zero loses selection #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,10 +22,6 @@ WYMeditor.UndoRedo = function (wym) { | |||
|
|
|||
| undoRedo.wym = wym; | |||
|
|
|||
| // https://github.com/mightyiam/object-history | |||
| undoRedo.history = new WYMeditor.EXTERNAL_MODULES | |||
| .ObjectHistory(wym.getCurrentState()); | |||
There was a problem hiding this comment.
This always produces a first undo point that is lacking selection.
That means that when undoing all the way back to the first point makes the selection go away, meaning the user must place the caret in order to type characters again.
|
In tests that test undo/redo, a In |
winhamwr
changed the title
winhamwr
added a commit
that referenced
this pull request
Apr 21, 2015
Undoing back to zero loses selection
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiate object-history on body focus