Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor into separate classes that are abstracted and use non-static methods #75

Closed
wynnset opened this issue Jul 2, 2019 · 0 comments · Fixed by #76
Closed

Refactor into separate classes that are abstracted and use non-static methods #75

wynnset opened this issue Jul 2, 2019 · 0 comments · Fixed by #76
Assignees

Comments

@wynnset
Copy link
Collaborator

wynnset commented Jul 2, 2019

Refactor as follows:

  • Separate nodes, links, and groups into their own controller function
  • For each new controller class, create private properties to keep track of the data for that class
  • Public classes should be abstract and not use any Wordpress functionality
  • Wordpress functions should only be called in private functions
@wynnset wynnset added this to the Sprint 5 - July 12 milestone Jul 2, 2019
@anhduc130 anhduc130 changed the title Refactor into separate classes that are abstracted and use static methods Refactor into separate classes that are abstracted and use non-static methods Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants