Skip to content

Commit

Permalink
obsolete TODO removed and debug added if a resource creates response …
Browse files Browse the repository at this point in the history
…directly
  • Loading branch information
michaelwechner committed Jan 20, 2012
1 parent 42e4b6f commit 63aeb3a
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/webapp/src/java/org/wyona/yanel/servlet/YanelServlet.java
Expand Up @@ -1884,10 +1884,12 @@ private boolean generateResponseFromResourceView(HttpServletRequest request, Htt

View view = ((ViewableV2) resource).getView(viewId);
if (view != null) {
log.warn("TODO: Tracking not implemented yet: " + resource.getPath());
TrackingInformationV1 trackInfo = null;
if (generateResponse(view, resource, request, response, getDocument(NAMESPACE, "yanel"), -1, -1, trackInfo) != null) return true;
if (generateResponse(view, resource, request, response, getDocument(NAMESPACE, "yanel"), -1, -1, trackInfo) != null) {
return true;
}
}
log.warn("No response has been generated: " + resource.getPath());
return false;
}

Expand Down Expand Up @@ -2051,14 +2053,15 @@ private void setExpiresHeader(HttpServletResponse response, int hours) {
private HttpServletResponse generateResponse(View view, Resource res, HttpServletRequest request, HttpServletResponse response, Document doc, long size, long lastModified, TrackingInformationV1 trackInfo) throws ServletException, IOException {
//log.debug("Generate response: " + res.getPath());

// TODO: There seem like no header fields are being set (e.g. Content-Length, ...). Please see below ...
// TODO: It seems like no header fields are being set (e.g. Content-Length, ...). Please see below ...

// INFO: Check if viewable resource has already created a response
if (!view.isResponse()) {
if(logAccessIsApplicable(view.getMimeType(), res)) {
//log.debug("Mime type '" + view.getMimeType() + "' of request: " + request.getServletPath() + "?" + request.getQueryString());
doLogAccess(request, response, res, trackInfo);
}
log.debug("It seems that resource '" + res.getPath() + "' has directly created the response.");
return response;
}

Expand Down

0 comments on commit 63aeb3a

Please sign in to comment.