Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocam focusing on Trombone clips through Stringed instrument #154

Closed
Alto1772 opened this issue Dec 23, 2022 · 2 comments · Fixed by #164
Closed

Autocam focusing on Trombone clips through Stringed instrument #154

Alto1772 opened this issue Dec 23, 2022 · 2 comments · Fixed by #164
Labels
bug Something isn't working or is incorrect

Comments

@Alto1772
Copy link

Title says it all, with camera coordinates zoomed in from below screenshot:
midis2jam2_TG4s3GujhP-1

full screenshot:
image
@Alto1772 Alto1772 added the bug Something isn't working or is incorrect label Dec 23, 2022
@wyskoj
Copy link
Owner

wyskoj commented Dec 27, 2022 •
edited

I've had plans to move the trombone entirely, so when I do that this will be resolved.

wyskoj added a commit that referenced this issue Jun 3, 2023
@wyskoj
Improve trombone position and animation
c7b1841 
Move the trombone to the other side of the stage and closer to the
front, so it can be seen better. Update auto-cam position for trombone.

Separate trombone body and horn so that it stretches like all other
brass instruments.

Improve slide movement anticipation to produce more desirable animation.

Fixes #154
@wyskoj wyskoj linked a pull request Jun 3, 2023 that will close this issue
Improvements to trombone position and animation #164
Merged
wyskoj added a commit that referenced this issue Jun 3, 2023
@wyskoj
Improve trombone position and animation
2e04b0d 
Move the trombone to the other side of the stage and closer to the
front, so it can be seen better. Update auto-cam position for trombone.

Separate trombone body and horn so that it stretches like all other
brass instruments.

Improve slide movement anticipation to produce more desirable animation.

Fixes #154
@s11141827

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements to trombone position and animation wyskoj/midis2jam2
3 participants
@wyskoj @Alto1772 @s11141827