-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pitch bend visualization #65
Comments
57d412e adds this for fretted instruments. I think there's only a few other types of instruments I want to add this for, so I'll close this once I finish that. |
Guitars and Space Lasers are finished. Remaining instruments to animate pitch-bend:
|
This looks cursed but sounds interesting! |
9fd23ec adds pitch bend animation for saxophones. |
Interesting idea, I'll give it a try! |
Is it just me or have I not seen the trombones utilize this at all when it should? I mean, come on, the trombone should at least have that classic slide action that occurs in real life right? |
Add pitch bend support for: - French horn - Trombone - Trumpet - Tuba - Flute - Ocarina - Piccolo - Recorder - Clarinet - Oboe Refine pitch bend support for saxophones.
This is complete now! At this point, stage brass is not animated and I don't plan on adding pitch bend support for it. |
Is your feature request related to a problem? Please describe.
Kinda, currently when the pitchwheel is used there is no visual indication that it was, so it feels like something that should be there is missing, specially noticeable when the pitchslide is slow and/or is sliding through a lot of semitones
Describe the solution you'd like
A clear and concise description of what you want to happen.
First of you would have to detect the current pitch bend range set on every midi channel that have CC100 at 0 and CC101 at 0, then CC6 becomes how many semitones the pitch bend range is.
Here my ideas:
For guitars and bass at least the "finger" could smoothly go up and down
For pianos/organs you could put a (pretty big so it's visible) pitch bend wheel on them like a real midi piano and maybe a led number close to the pitch bend wheel saying how many semitones the pitch bend range is set at
With midi you can pitch bend literally any instrument unregarding wherever you can in real life or not
For example a flute physically can't irl so how would pitchbend be implemented? Well simply by being way less precise and only have visual movement on it if the pitch is bent for example 51 to 150 cents the fingers would go to the position to play the next semitone, most of the left instruments apart from the pianos/guitar/bass would have to be implemented like this
Then there are the instruments that would be completely pointless to have visual pitch bend like a timpani
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Well an way easier implementation would be to simply put a floating pitch bend wheel next to the instruments that would only appear if the pitch wheel value is changed for ALL instruments, but I'm not too sure about this one
The text was updated successfully, but these errors were encountered: