Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pitch bend visualization #65

Closed
VGMRUS opened this issue Nov 8, 2021 · 11 comments
Closed

Add pitch bend visualization #65

VGMRUS opened this issue Nov 8, 2021 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@VGMRUS
Copy link

VGMRUS commented Nov 8, 2021

Is your feature request related to a problem? Please describe.

Kinda, currently when the pitchwheel is used there is no visual indication that it was, so it feels like something that should be there is missing, specially noticeable when the pitchslide is slow and/or is sliding through a lot of semitones

Describe the solution you'd like
A clear and concise description of what you want to happen.

First of you would have to detect the current pitch bend range set on every midi channel that have CC100 at 0 and CC101 at 0, then CC6 becomes how many semitones the pitch bend range is.

Here my ideas:
For guitars and bass at least the "finger" could smoothly go up and down
For pianos/organs you could put a (pretty big so it's visible) pitch bend wheel on them like a real midi piano and maybe a led number close to the pitch bend wheel saying how many semitones the pitch bend range is set at

With midi you can pitch bend literally any instrument unregarding wherever you can in real life or not
For example a flute physically can't irl so how would pitchbend be implemented? Well simply by being way less precise and only have visual movement on it if the pitch is bent for example 51 to 150 cents the fingers would go to the position to play the next semitone, most of the left instruments apart from the pianos/guitar/bass would have to be implemented like this

Then there are the instruments that would be completely pointless to have visual pitch bend like a timpani

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Well an way easier implementation would be to simply put a floating pitch bend wheel next to the instruments that would only appear if the pitch wheel value is changed for ALL instruments, but I'm not too sure about this one

@VGMRUS VGMRUS added the enhancement New feature or request label Nov 8, 2021
@wyskoj wyskoj changed the title Visual Pitchwheel Pitch Slides on Guitars/Bass (and other instruments?) Add pitch bend visualization Nov 13, 2021
@wyskoj
Copy link
Owner

wyskoj commented Nov 14, 2021

57d412e adds this for fretted instruments. I think there's only a few other types of instruments I want to add this for, so I'll close this once I finish that.

@VGMRUS
Copy link
Author

VGMRUS commented Nov 14, 2021

Nicely done, I love it, thanks for adding it, this is how it looks with vibrato manually made with the pitch bend wheel looks:

@VGMRUS
Copy link
Author

VGMRUS commented Nov 15, 2021

I just had a simple idea for adding pitch bend visualization for practically any floating (wind) instrument (not pianos), what if these instruments bended slightly upwards when the pitch bend wheel goes up and downwards when the pitch bend wheel goes down? Something like this:

Cheers

@wyskoj
Copy link
Owner

wyskoj commented Jan 18, 2022

Guitars and Space Lasers are finished. Remaining instruments to animate pitch-bend:

  • Keyboards — simple pitch and modulation wheel
  • Strings — maybe the strings could move up/down based on pitch-bend?
  • Woodwind and brass families — see above
  • Stage brass/choir — not sure, since they already move up and down...

@wyskoj wyskoj self-assigned this Jan 18, 2022
@VGMRUS
Copy link
Author

VGMRUS commented Jan 18, 2022

Guitars and Space Lasers are finished. Remaining instruments to animate pitch-bend:

* [ ]  Keyboards — simple pitch and modulation wheel

* [ ]  Strings — maybe the strings could move up/down based on pitch-bend?

* [ ]  Woodwind and brass families — see above

* [ ]  Stage brass/choir — not sure, since they already move up and down...

Good job, I like all the ideas, I have an idea for choir, what if they tilted their heads up and down depending on the pitch wheel position? I know it looks a bit weird but it's because it's a photoshop, on the 3D model it should be fine
Pitchbend instrument angle example 2

@wyskoj
Copy link
Owner

wyskoj commented Jan 18, 2022

This looks cursed but sounds interesting!

@wyskoj
Copy link
Owner

wyskoj commented Feb 20, 2022

9fd23ec adds pitch bend animation for saxophones.

@TheCococQuartz
Copy link

I had an idea for how the Stage Brass should animate pitch bends, this requires changing how the Brass is displayed regulary but idk this might be a good idea
IdeaForBrass

@wyskoj
Copy link
Owner

wyskoj commented Mar 21, 2022

Interesting idea, I'll give it a try!

@TrikiNya
Copy link

Is it just me or have I not seen the trombones utilize this at all when it should? I mean, come on, the trombone should at least have that classic slide action that occurs in real life right?

wyskoj added a commit that referenced this issue Aug 5, 2022
wyskoj added a commit that referenced this issue Aug 14, 2022
Add pitch bend support for:
 - French horn
 - Trombone
 - Trumpet
 - Tuba
 - Flute
 - Ocarina
 - Piccolo
 - Recorder
 - Clarinet
 - Oboe

Refine pitch bend support for saxophones.
wyskoj added a commit that referenced this issue Oct 9, 2022
@wyskoj
Copy link
Owner

wyskoj commented Feb 9, 2024

This is complete now!

At this point, stage brass is not animated and I don't plan on adding pitch bend support for it.

@wyskoj wyskoj closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants