Feature/3 catch up subscriptions #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
June 8, 2016 17:07
… (still in progress), meant to be a port of the same module from the official .NET Event Store client.
…. Almost done readEVentsTill method. Not yet implemented tryProcess.
…t implemented (due to missing functionality in the connection module) but is stubbed here as a signpost for future development.
…nection method subscribeToStreamFrom (which is an entry point to a stream-based catch-up subscription).
…ing it as "eventstore". This will facilitate using different host names on different development environments.
…nection info for tests.
…and to generate and write test events, and finally to delete given test streams.
…ic desired functionality verified.
…lter code interfaces for conformity to existing ones (cosmetic changes only)
|
Awesome, tests and docs included! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pertaining to issue #3, I have ported the catch-up subscription functionality from the official Event Store .NET client.
As of now only single-stream catch-up subscriptions are implemented, not all-event catch-up subscriptions, primarily because the
subscribeToAllfunctionality seems to be missing from the Connection class. As I don't need subscribe-to-all right now, I've chosen not to implement it for this pull request.I added one (tiny) additional package: the
argument-validatorpackage - just for some quick argument validation. That package has no dependencies of its own; it's very lightweight.In addition to the new code, I have updated the README file and the TypeScript definitions.
There are some new Mocha tests in the testing area, all working on a bare-bones installation of Event Store. The tests create and destroy randomly named streams. As part of adding the new test code, I've centralized some of the common test functionality and adding quick utilities for generating and writing test events.