Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring tabs component in line with Nunjucks macro #220

Merged
merged 4 commits into from
Jul 25, 2021

Conversation

peteryates
Copy link
Member

This mostly makes the tabs component work like the original Nunjucks macro.

The one difference is that because here we're generating the tab ids based on the title label, there's no real need for idPrefix.

Providing the user doesn't have two tabs with the same name, the ids will be unique.

Changes

  • Stop using matcher now we're using the tag helper
  • Allow the tabs component to take a custom id
  • Rename the tab slot's title to label
  • Allow tab text to be set via arg as well as block

@peteryates peteryates merged commit 5238be5 into version-2.0.0 Jul 25, 2021
@peteryates peteryates deleted the version-2.0.0-pp-tabs branch July 25, 2021 11:33
@peteryates peteryates added this to the Version 2.0.0 milestone Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant