Rewrite the summary list (with slots all the way down 馃悽) #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary list rows are too flexible for regular arguments, because: * key can be set with either text or HTML * value can be set with either text or HTML * there can be multiple actions * each action can have its text set with text or HTML * keys, values and actions all accept custom classes and HTML attributes The only way to solve this without making it massively complicated is to use slots all the way down.
Using Ruby's methods that end with a question mark in ternary statements is ugly because of the two question marks a space apart that have entirely different meanings: some_condition? ? when_true : when false Wrapping the condition in parens is the only elegant solution (other than just constructing it differently to appease Rubocop). (some_condition?) ? when_true : when false Should probably be disabled by default
peteryates
force-pushed
the
version-2.0.0-pp-summary-list
branch
from
5ce3d25
to
b422a63
Compare
This was referenced Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary list rows are too flexible for regular arguments, because:
Multi-level slots are the only way to achieve the above requirements without making the arguments incredibly complicated.