Rewrite the cookie banner with slots #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteryates
force-pushed
the
version-2.0.0-pp-cookie-banner
branch
from
461e3af
to
682eaae
Compare
This now works in a very similar fashion to the Nunjucks macros. Instead of passing in actions with arguments it supports the passing in of any arbitrary HTML, the intention is for developers to pass in an array of buttons or links generated by `govuk_link_to` or similar. These will then automatically be wrapped in a `govuk-button-group`.
peteryates
force-pushed
the
version-2.0.0-pp-cookie-banner
branch
from
682eaae
to
67eca54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now works in a very similar fashion to the Nunjucks macros. Instead of passing in actions with arguments it supports the passing in of any arbitrary HTML, the intention is for developers to pass in an array of buttons or links generated by
govuk_link_toor similar. These will then automatically be wrapped in agovuk-button-group.