Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details component #25

Merged
merged 3 commits into from
May 22, 2020
Merged

Details component #25

merged 3 commits into from
May 22, 2020

Conversation

peteryates
Copy link
Member

Add the details component and basic specs

@peteryates peteryates mentioned this pull request May 22, 2020
Closed
21 tasks
rjlynch
rjlynch approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run the rake task in the dummy app to update the docs page? bin/rake generate_examples_page
Code works and LGTM 👍

@peteryates peteryates merged commit f5bcdfa into master May 22, 2020
@peteryates peteryates deleted the details branch May 22, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peteryates @rjlynch