Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification banners #71

Merged
merged 10 commits into from
Dec 7, 2020
Merged

Notification banners #71

merged 10 commits into from
Dec 7, 2020

Conversation

peteryates
Copy link
Member

@peteryates peteryates commented Dec 1, 2020 •
edited
Loading

First draft of a notification banners component. It doesn't support every option yet but has a sensible-feeling set of params.

  • add support for titleHeadingLevel, titleId, disableAutoFocus
  • Improve the full stop behaviour, it shouldn't be part of the link 🤦🏽 (thanks for pointing that out @frankieroberto - totally missed it)

Screenshot from 2020-12-02 16-51-09

Fixes #70

@peteryates
Add the notification banner component
1275392 
Refs #70
@peteryates
Register the notification banner helper
fb60280 
Refs #70
@peteryates
Add some notification banner demos
a694a82 
This required that govuk-frontend was updated hence the minified
JavaScript file

Refs #70
@peteryates peteryates mentioned this pull request Dec 1, 2020
Closed
@peteryates peteryates merged commit 7ebc4af into master Dec 7, 2020
@peteryates peteryates deleted the notification-banners branch December 7, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification banner component
1 participant
@peteryates