Allow users to provide a SCSS file that contains settings for GOV.UK Frontend #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrobertlloyd
force-pushed
the
sass-settings-file
branch
from
7618cd6
to
80a663d
Compare
This was referenced Dec 9, 2023
paulrobertlloyd
force-pushed
the
sass-settings-file
branch
from
80a663d
to
7ab0695
Compare
paulrobertlloyd
force-pushed
the
sass-settings-file
branch
from
7ab0695
to
a700cd7
Compare
|
An example of this being implemented on the Classnames website: paulrobertlloyd/classnames@78ed4a9 |
paulrobertlloyd
force-pushed
the
sass-settings-file
branch
from
a700cd7
to
fec66c1
Compare
frankieroberto
approved these changes
Dec 11, 2023
paulrobertlloyd
force-pushed
the
govuk-frontend-5
branch
2 times, most recently
from
733c908
to
621886d
Compare
paulrobertlloyd
force-pushed
the
sass-settings-file
branch
from
fec66c1
to
4faee90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #178 and #193. Depends on #214 1.
Taking a leaf out of the GOV.UK Prototype Kit, and using the same file location (by default), instead of adding additional options to the plugin… and then parsing them… and documenting them… and keeping them in sync with upstream changes in GOV.UK Frontend… no, instead of all that malarkey, allow users to supply a file at
{dir.input}/assets/sass/settings.scss. This path can be overridden using thescssSettingsPathoption.Footnotes
There isn’t a code dependency, but this will be included as part of v6.0 which uses
govuk-frontendv5, so want to make sure the 2 work together. ↩