Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t wrap submit buttons in govuk-form-group #105

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Don’t wrap submit buttons in govuk-form-group #105

merged 1 commit into from
Mar 30, 2020

Conversation

duncanjbrown
Copy link
Contributor

Following discussion on DfE Slack, don't wrap submit elements in an unnecessary govuk-form-group.

peteryates
peteryates requested changes Mar 30, 2020
View reviewed changes
Copy link
Member

@peteryates peteryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the fg variable needs changing to subject.

spec/govuk_design_system_formbuilder/builder/submit_spec.rb Outdated Show resolved Hide resolved
@duncanjbrown
Don’t wrap submit buttons in govuk-form-group
53d4d7a 
This isn't part of the design system
@duncanjbrown duncanjbrown force-pushed the remove-govuk-form-group-wrap-on-submits branch from 16963ce to 53d4d7a Compare March 30, 2020 13:08
peteryates
peteryates approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@peteryates peteryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@peteryates peteryates merged commit 12dffde into x-govuk:master Mar 30, 2020
@duncanjbrown duncanjbrown deleted the remove-govuk-form-group-wrap-on-submits branch March 30, 2020 13:29
@peteryates peteryates mentioned this pull request Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteryates peteryates peteryates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@duncanjbrown @peteryates