Providing procs to collection helpers #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollectionItem will hold functionality that's specific to items belonging to a collection. Initially, this covers the retrieval of the value depending on what's passed into the :text_method, :value_method or :hint_method params. These arguments now accept and properly deal with procs Refs #68
Instead of using `#send` inline to retrieve the value from `@item`, make use of `#retrieve` which works with procs. Refs #68
The :value_method, :text_method and :hint_method params passed to radio collections and the :hint_method params passed to checkbox collections now accept procs which can be used to customise the value retrieved from the item. This could be used for simple transformations like upcasing the text or more-complex operations like localising the value, as per the provided specs Refs #68
Some builds are failing before the lint/tests are run (when installing and compiling gems). Try temporarily disabling the cache
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows procs to be provided to the
#collection_radio_buttonsand#collection_check_boxeshelpers':value_method,:text_methodandhint_methodparams. These could be used for simple operations like transforming (eg calling#upcase) on the retrieved string. Alternatively, it could be used in the following manner to allow the labels and hints to be fully localisedRefs #68