Skip to content

Commit

Permalink
Merge pull request #259 from motemen/log
Browse files Browse the repository at this point in the history
enhance logs on ghq get
  • Loading branch information
Songmu committed Jan 4, 2020
2 parents 4ce1042 + 065c541 commit a2acdc0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cmd_get.go
Expand Up @@ -63,18 +63,18 @@ func doGet(c *cli.Context) error {
eg.Go(func() error {
defer func() { <-sem }()
if err := g.get(target); err != nil {
logger.Log("error", err.Error())
logger.Logf("error", "faied to get %q: %s", target, err)
}
return nil
})
} else {
if err := g.get(target); err != nil {
return err
return fmt.Errorf("failed to get %q: %w", target, err)
}
}
}
if err := scr.Err(); err != nil {
return fmt.Errorf("While reading input: %s", err)
return fmt.Errorf("error occurred while reading input: %w", err)
}
if err := eg.Wait(); err != nil {
return err
Expand Down
6 changes: 6 additions & 0 deletions logger/log.go
@@ -1,6 +1,7 @@
package logger

import (
"fmt"
"io"
"os"

Expand Down Expand Up @@ -41,3 +42,8 @@ func SetOutput(w io.Writer) {
func Log(prefix, message string) {
logger.Log(prefix, message)
}

// Logf output log with format
func Logf(prefix, msg string, args ...interface{}) {
Log(prefix, fmt.Sprintf(msg, args...))
}

0 comments on commit a2acdc0

Please sign in to comment.