Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Ignore files which seems to system hidden file in walking #176

Merged
merged 1 commit into from
May 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions list_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,8 @@ func TestDoList_unique(t *testing.T) {

func TestDoList_unknownRoot(t *testing.T) {
defer func(orig []string) { _localRepositoryRoots = orig }(_localRepositoryRoots)
defer func(orig string) { os.Setenv("GHQ_ROOT", orig) }(os.Getenv("GHQ_ROOT"))

defer tmpEnv("GHQ_ROOT", "/path/to/unknown-ghq")()
_localRepositoryRoots = nil
os.Setenv("GHQ_ROOT", "/path/to/unknown-ghq")

err := newApp().Run([]string{"ghq", "list"})
if err != nil {
Expand All @@ -187,19 +185,37 @@ func TestDoList_unknownRoot(t *testing.T) {

func TestDoList_notPermittedRoot(t *testing.T) {
defer func(orig []string) { _localRepositoryRoots = orig }(_localRepositoryRoots)
defer func(orig string) { os.Setenv("GHQ_ROOT", orig) }(os.Getenv("GHQ_ROOT"))
tmpdir := newTempDir(t)
defer func(dir string) {
os.Chmod(dir, 0755)
os.RemoveAll(dir)
}(tmpdir)
defer tmpEnv("GHQ_ROOT", tmpdir)()

_localRepositoryRoots = nil
os.Setenv("GHQ_ROOT", tmpdir)
os.Chmod(tmpdir, 0000)

err := newApp().Run([]string{"ghq", "list"})
if !os.IsPermission(xerrors.Unwrap(err)) {
t.Errorf("error should be ErrNotExist, but: %s", err)
}
}

func TestDoList_withSystemHiddenDir(t *testing.T) {
defer func(orig []string) { _localRepositoryRoots = orig }(_localRepositoryRoots)
tmpdir := newTempDir(t)
systemHidden := filepath.Join(tmpdir, ".system")
os.MkdirAll(systemHidden, 0000)
defer func(dir string) {
os.Chmod(systemHidden, 0755)
os.RemoveAll(dir)
}(tmpdir)
defer tmpEnv("GHQ_ROOT", tmpdir)()

_localRepositoryRoots = nil

err := newApp().Run([]string{"ghq", "list"})
if err != nil {
t.Errorf("error should be nil, but: %s", err)
}
}
3 changes: 3 additions & 0 deletions local_repository.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,9 @@ func walkLocalRepositories(callback func(*LocalRepository)) error {
if err == nil || os.IsNotExist(err) {
return nil
}
if os.IsPermission(err) && filepath.Base(fpath)[0] == '.' {
return nil
}
return err
}
if fi.Mode()&os.ModeSymlink == os.ModeSymlink {
Expand Down