Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bazaar #87

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Support bazaar #87

merged 1 commit into from
Apr 30, 2019

Conversation

shigemk2
Copy link
Contributor

@shigemk2 shigemk2 commented Oct 8, 2017

Config

[ghq]
    vcs = bazaar

Examples

$ ghq get https://launchpad.net/terminator
     clone https://launchpad.net/terminator -> /path/to/launchpad.net/terminator
       bzr branch https://launchpad.net/terminator /path/to/launchpad.net/terminator
Branched 1779 revisions.
$ ghq get -u https://launchpad.net/terminator
    update /path/to/launchpad.net/terminator
       bzr pull
Using saved parent location: http://bazaar.launchpad.net/~gnome-terminator/terminator/gtk3/
No revisions or tags to pull.

@shigemk2
Copy link
Contributor Author

@motemen Please review this PR 😄

@motemen
Copy link
Member

motemen commented Feb 6, 2018

Thanks. I'm not familier with Bazaar, and I am slightly confused about that there are two different ways (checkout and branch) to clone repositories. Is there a "default" way to clone repositories? I'd like to choose one as default, so that we can use vcs = bazaar for default clone strategy.

Seeing some docs (eg. http://doc.bazaar.canonical.com/migration/en/survival/bzr-for-git-users.html), bzr branch seems suitable to be a default way for cloning in Bazaar.

@Songmu
Copy link
Member

Songmu commented Apr 26, 2019

It is a good idea to support bazzar.
I agree with motemen and we should be able to specify VCS simply by bazzar or bzr (similar to go get).

The feature of branch specification may be considered in the future as a unified function of ghq overall.

How about it ? @shigemk2

@shigemk2
Copy link
Contributor Author

@Songmu @motemen

I am not sure which bzr branch or bzr checkout is "default" way because I am not familiar with Bazaar neither.

But I agree with vcs = bazaar as "default" way.

@Songmu
Copy link
Member

Songmu commented Apr 27, 2019

I'm also not familiar with bazzar, but the behavior of "go get" will be helpful for you.

Config:

[ghq]
    vcs = bazaar

Examples:

$ ghq get https://launchpad.net/terminator
     clone https://launchpad.net/terminator -> /path/to/launchpad.net/terminator
       bzr branch https://launchpad.net/terminator /path/to/launchpad.net/terminator
$ ghq get -u https://launchpad.net/terminator
    update /path/to/launchpad.net/terminator
       bzr pull
@shigemk2 shigemk2 changed the title Support bazaar checkout and bazaar branch Support bazaar Apr 30, 2019
@shigemk2
Copy link
Contributor Author

@Songmu
I changed bzr branch when executing ghq get. Please review this PR again.

@Songmu
Copy link
Member

Songmu commented Apr 30, 2019

Great! Thank you.

@Songmu Songmu merged commit a4ed972 into x-motemen:master Apr 30, 2019
@shigemk2
Copy link
Contributor Author

You are welcome!!

Songmu added a commit that referenced this pull request May 1, 2019
## [v0.11.0](v0.10.2...v0.11.0) (2019-05-01)

* Delete codes for the services turned down (Google Code and JazzHub) [#144](#144) ([Songmu](https://github.com/Songmu))
* reduce linter warnings [#143](#143) ([Songmu](https://github.com/Songmu))
* remove ghq.import.<subcommand> feature [#137](#137) ([Songmu](https://github.com/Songmu))
* Remove gomega [#142](#142) ([Songmu](https://github.com/Songmu))
* Streamline VCS detection for local repositories [#141](#141) ([Songmu](https://github.com/Songmu))
* introduce table driven test in TestCommandGet [#140](#140) ([Songmu](https://github.com/Songmu))
* "bzr" as Bazaar [#139](#139) ([Songmu](https://github.com/Songmu))
* Support bazaar [#87](#87) ([shigemk2](https://github.com/shigemk2))
* [experimental] support parallel import by using --parallel option [#136](#136) ([Songmu](https://github.com/Songmu))
* add -silent option to get and import [#135](#135) ([Songmu](https://github.com/Songmu))
* Stop exec on unix in the look subcommand in order to share code with windows [#134](#134) ([Songmu](https://github.com/Songmu))
* [list] accept url as a query [#133](#133) ([Songmu](https://github.com/Songmu))
* adjust NewURL() [#132](#132) ([Songmu](https://github.com/Songmu))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants