Aggregate labels from merged pull requests #56
Conversation
ohbarye
force-pushed
the
aggregate-labels-from-prs
branch
from
8671969
to
9263223
Compare
| :assignees: [] | ||
| :requested_reviewers: [] | ||
| :requested_teams: [] | ||
| :labels: [] | ||
| :milestone: | ||
| :labels: |
There was a problem hiding this comment.
📝 This example comes from the ofiicial API reference.
https://docs.github.com/en/rest/reference/pulls#get-a-pull-request--code-samples
| @@ -75,7 +76,8 @@ def configure | |||
| say "Production branch: #{production_branch}", :debug | |||
| say "Staging branch: #{staging_branch}", :debug | |||
| say "Template path: #{template_path}", :debug | |||
| say "Labels #{labels}", :debug | |||
| say "Labels: #{labels}#{aggregate_labels ? ' + labels on merged PRs' : ''}", :debug | |||
There was a problem hiding this comment.
I wanted to show merged labels but it couldn't determine all labels to be added here.
Because it calls fetch_merged_prs after configure.
Due to the same reason, I was compelled to add a destructive substitution to @labels in fetch_merged_prs.
git-pr-release/lib/git/pr/release/cli.rb
Line 122 in 9263223
ohbarye
changed the title
``` $ git config pr-release.aggregate_labels error: invalid key: pr-release.aggregate_labels ```
ohbarye
changed the title
|
This change got unnecessary for me, so I'm closing. |
|
@ohbarye I believe this feature is exactly what my team needs. Would it be possible for you to reopen this pull request, or would you prefer that I take over the work? |
|
@masaru-iritani Sure. Please go ahead as you like! |
@onk @motemen
Issue
Closes #54
Changes
As described in #54, I added
aggregate_labelsfeature.pr-release.aggregate_labelsconfig (orGIT_RELEASE_PR_AGGREGATE_LABELS)."true"or anything"true",git-release-praggregates labels from merged pull requests.pr-release.labelsis given at the same time?pr-release.labelssetting.pr-release.labels=foo,barand aggregated labels arebaz, then labels would be["foo", "bar", "baz"].Testing
That worked well on my own
$ GIT_PR_RELEASE_BRANCH_STAGING=release GIT_PR_RELEASE_LABELS=release GIT_PR_RELEASE_AGGREGATE_LABELS=true bundle exec git-pr-releaseReview Points
aggregate_labelsan appropriate name?reuse_labels,summarize_labels... etc.aggregate_labelsbe given as a command line arg, not environment variable or git config?--dry-run,--no-fecth,aggregate_labelsis boolean-ish value. So I wonder if it should be. (It depends on this gem's command line design.)