Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonarqube Fixes #298

Open
gorky opened this issue Jul 4, 2022 · 0 comments
Open

Sonarqube Fixes #298

gorky opened this issue Jul 4, 2022 · 0 comments

Comments

@gorky
Copy link
Contributor

gorky commented Jul 4, 2022

I ran this project through Sonarqube and it found a bunch of issues. I have an automated solution for fixing issues. As handling is added for fixing issues, I will submit the patches under this ticket. Next round of updates should be along in the next day or two.

If anyone would like access to the Sonarqube server with the scan results, please DM me and I will set you up.

There will be additional updates as the Honor Systems Updater is enhanced to handle more issues and scenarios. As a result, I would suggest keeping this ticket open as there will be additional commits under this topic.

(Similar to #296 - but additional fixes).

sanddusttx added a commit to sanddusttx/xstream that referenced this issue Jul 4, 2022
x-stream#298
Use Charsequence and StringBuilder rather than StringBuffer

Also-by: Stephen Davidson <steve@j2eeguys.com>
Signed-off-by: Sanddust <sanddust@j2eeguys.com>
gorky added a commit to j2eeguys/xstream that referenced this issue Jul 6, 2022
x-stream#298
Use Charsequence and StringBuilder rather than StringBuffer
With assist from Honor Systems Updater.

Signed-off-by: Steve Davidson <steve@j2eeguys.com>
hsujenkins added a commit to j2eeguys/xstream that referenced this issue Jul 6, 2022
x-stream#298
Automatic updates
https://jenkins.updater.j2eeguys.com/
xstream/src/java/com/thoughtworks/xstream/core/util/FastStack.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xstream/src/java/com/thoughtworks/xstream/io/path/PathTracker.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xstream/src/java/com/thoughtworks/xstream/io/xml/AbstractPullReader.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xstream/src/java/com/thoughtworks/xstream/io/xml/XomReader.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xstream-benchmark/src/java/com/thoughtworks/xstream/tools/benchmark/reporters/HtmlReporter.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xstream/src/java/com/thoughtworks/xstream/io/xml/XmlFriendlyNameCoder.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xstream/src/java/com/thoughtworks/xstream/core/util/XmlHeaderAwareReader.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xstream-benchmark/src/java/com/thoughtworks/xstream/tools/benchmark/reporters/TextReporter.java
    Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder". [java:S1149]
xstream/src/java/com/thoughtworks/xstream/io/xml/DomDriver.java
    Disable access to external entities in XML parsing. [java:S2755]

Also-by: Stephen Davidson <steve@j2eeguys.com>
Signed-off-by: Honor Systems Updater Jenkins <hsujenkins@j2eeguys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant