Memory allocation optimizations #350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in case of cache hit
Speeds up `FieldKey` constructor, hence `FieldDictionary.fieldOrNull`
…places Avoid generating instances of `FastField` when other already existing objects could be used as map keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While processing several memory dumps and allocation reports, I've spotted significant amount of
FieldKey,FastField,LinkedListandLinkedList$Itrobjects.It seems most of them are on-time used in some check.
So here are three commits, each one fixes usage of one of the aforementioned classes.
Targeting branch
v-1.4.x, as we've using it on our fork, and it could be beneficial to other xstream users. Feel free to cherry-pick tomasterbranch as well.