Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attribute-embedded HTML #3

Open
csuwildcat opened this issue Feb 5, 2014 · 0 comments
Open

Remove attribute-embedded HTML #3

csuwildcat opened this issue Feb 5, 2014 · 0 comments

Comments

@csuwildcat
Copy link
Member

Embedding chunks of HTML in attributes is a very bad practice, we should not do this with any component. The answer is to use a few tailored methods to provide a window into Shadow DOM - it should use Shadow DOM when present, and allow content manipulation in a backwards compatible way when it isn't.

I would be sad to see this go out in this state - we should make one change: make the label write to textContent instead of innerHTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant