You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Embedding chunks of HTML in attributes is a very bad practice, we should not do this with any component. The answer is to use a few tailored methods to provide a window into Shadow DOM - it should use Shadow DOM when present, and allow content manipulation in a backwards compatible way when it isn't.
I would be sad to see this go out in this state - we should make one change: make the label write to textContent instead of innerHTML.
The text was updated successfully, but these errors were encountered:
Embedding chunks of HTML in attributes is a very bad practice, we should not do this with any component. The answer is to use a few tailored methods to provide a window into Shadow DOM - it should use Shadow DOM when present, and allow content manipulation in a backwards compatible way when it isn't.
I would be sad to see this go out in this state - we should make one change: make the label write to
textContent
instead ofinnerHTML
.The text was updated successfully, but these errors were encountered: