Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Input throws error with new PHP_CodeSniffer #578

Closed
bordoni opened this issue Jun 23, 2014 · 3 comments
Closed

Filter Input throws error with new PHP_CodeSniffer #578

bordoni opened this issue Jun 23, 2014 · 3 comments
Labels

Comments

@bordoni
Copy link
Contributor

bordoni commented Jun 23, 2014

I have my version (on my own plugin) of the WP_Stream_Filter_Input that you guys are using here.

            case INPUT_COOKIE :
                $super = $_COOKIE; // HERE
                break;

On these lines the newest version of WordPress-Coding-Standards (released these days), brings up the following message:

Due to using Batcache, server side based client logic will not work, use JS instead.

This is related to the usage of Batcache on VIP correct? (http://vip.wordpress.com/documentation/batcache/#avoid-server-side-operations)

I'm using the same phpcs.ruleset.xml as you guys are using here, as I couldn't create an issue on PHP_CodeSniffer Repo, I thought here would be a good place as it happens on a file of this repo.


Update: I will create the issue on the WordPress-Coding-Standards, my bad I was trying to create it on the PHP_CodeSniffer repo, which is not the case here.

@fjarrett fjarrett added the bug label Jul 7, 2014
@fjarrett
Copy link
Contributor

/cc @westonruter @shadyvb

@westonruter
Copy link
Contributor

@bordoni Use the WordPress-Core subset standard instead of just the WordPress standard. The latter is a superset that includes VIP sniffs as well as extras.

@bordoni
Copy link
Contributor Author

bordoni commented Jul 12, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants