Fix SelectBox width of items elements #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyronald
approved these changes
Jan 18, 2019
nicksp
approved these changes
Jan 21, 2019
nicksp
pushed a commit
that referenced
this pull request
Jan 21, 2019
* Fix SelectBox width of items elements * Build app # Conflicts: # lib/auto-ui.js.map
Merged
nicksp
added a commit
that referenced
this pull request
Jan 21, 2019
* Truncate long attached file names (#320) * Truncate long attached file names * Update lineHeight * Build app # Conflicts: # lib/auto-ui.js.map * Implement RichTextEditor component in Note component (#321) * Implement RichTextEditor component in Note component + Add `disabled` prop to `RichTextEditor` Closes XP-2673 * Build lib + update snapshots * Rename `markdown` prop to `value` # Conflicts: # lib/auto-ui.js.map * Fix SelectBox's dissmissing messages behaviour (#319) * Fix SelectBox's dissmissing messages behaviour * Include dissmising of deletion messages at SelectBox unmounting * Prevent unnecessary action triggers # Conflicts: # lib/auto-ui.js.map * Add default toolbar items (#326) * Add default toolbar items * Remove export elements and update stories book * Rollback css changes * Declare only one default toolbar variable * Build app # Conflicts: # lib/auto-ui.js.map * Update top profile design (#325) * Upgrade button and SvgIcon component to adapt new style on auto (#322) * Upgrade button and Svg component to adapt new style on auto * Add new props to button component: icon, iconProps and contentStyle * Add new color to Svgicon and new custom style for button components * Build app * Add Activity Header (#324) * Add time SvgIcon * Add Activity Header * Fix flexbox for grid * Add build * Address PR requested changes * Fix activity description `line-height` + remove `min-width` * Remove `max-width` * Use `rem` instead of `px` fot font-size + Fix snapshots * Update padding button fro sourceSansPro content style * Build app # Conflicts: # lib/auto-ui.js.map * Add bottom padding to RichTextEditor (#329) * Add bottom padding for rich text editor * Update test * Add build * Fix SelectBox width of items elements (#330) * Fix SelectBox width of items elements * Build app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Type: Non-Breaking Feature
Fixes https://x-team-internal.atlassian.net/browse/XP-2721
Description
Checklist
Before submitting a pull request, please make sure the following is done:
In RevieworIn Progressdepending on its status)IN REVIEWcolumnnpm run lint)npm run flow)npm run jest).stories.jsfile) is changed or added accordingly to reflect any new or updated use cases or variants usage.Related PRs
Impacted Areas in Application
Screenshots