Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArticleInfo API: cache if the query took 5 seconds #114

Merged
merged 1 commit into from Oct 17, 2017

Conversation

MusikAnimal
Copy link
Member

Move API code to ArticleInfo controller

Bug: https://phabricator.wikimedia.org/T175763

@codecov
Copy link

codecov bot commented Oct 17, 2017

Codecov Report

Merging #114 into master will increase coverage by 1.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   43.43%   44.66%   +1.23%     
==========================================
  Files          34       34              
  Lines        2816     2765      -51     
==========================================
+ Hits         1223     1235      +12     
+ Misses       1593     1530      -63
Impacted Files Coverage Δ
src/AppBundle/Controller/ApiController.php 13.46% <ø> (+4.42%) ⬆️
src/AppBundle/Controller/ArticleInfoController.php 90.9% <ø> (+90.9%) ⬆️
src/AppBundle/Controller/XtoolsController.php 50.38% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7febf54...6739d11. Read the comment docs.

@MusikAnimal MusikAnimal force-pushed the cache-article-info-api branch 4 times, most recently from b38b6f2 to 9574064 Compare October 17, 2017 01:47
@MusikAnimal MusikAnimal merged commit 57c0a71 into master Oct 17, 2017
@MusikAnimal MusikAnimal deleted the cache-article-info-api branch October 17, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants