Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nokogiri #7

Merged
merged 3 commits into from
Jan 17, 2014
Merged

Use nokogiri #7

merged 3 commits into from
Jan 17, 2014

Conversation

swalberg
Copy link
Contributor

Fixes #7

Switched XML parsing to use nokogiri instead of REXML.

Test suite runs in 1s using nokogiri vs 19s using REXML.

x12(master %) $ time RUBYLIB="./lib" ruby ./benchmark.rb

real    0m1.478s
user    0m1.421s
sys 0m0.056s

x12(master %) $ git checkout use_nokogiri
Switched to branch 'use_nokogiri'
x12(use_nokogiri %) $ time RUBYLIB="./lib" ruby ./benchmark.rb

real    0m0.253s
user    0m0.197s
sys 0m0.051s
x12(use_nokogiri) $ time rspec
...............................................................................

Finished in 0.33452 seconds
79 examples, 0 failures

real    0m1.026s
user    0m0.881s
sys 0m0.134s
x12(use_nokogiri) $ git checkout master
Switched to branch 'master'
x12(master %) $ time rspec
.....................................................................

Finished in 18.49 seconds
69 examples, 0 failures

real    0m19.175s
user    0m18.753s
sys 0m0.411s

swalberg added a commit that referenced this pull request Jan 17, 2014
@swalberg swalberg merged commit 50b4072 into master Jan 17, 2014
@swalberg swalberg deleted the use_nokogiri branch January 17, 2014 16:52
@swalberg swalberg mentioned this pull request Jan 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant