Implement database migrations for Postgres backend #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents attempts to (re-)create the postgres schema with every instance of the alerta application. When running with multiple workers, e.g. via gunicorn, each worker attempts to run
sql/schema.sql
. This sometimes causes deadlocks, and if running withraise_on_error=False
, it ends up not being able to register theHistory
type (due to missingconn.rollback()
).After this moment, you have a worker that is broken and all requests routed to said worker end up returning a
psycopg2.ProgrammingError: can't adapt type 'History'
exception.With the introduction of migrations, we can reliably track the state of the database schema and ensure that no unnecessary database calls are made and reduce the amount of queries made on worker startup.
Changes
Include a brief summary of changes...
sql/
directory to follow a<version>_<name>.sql
for ordering the migrationsChecklist