Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and potentially remove custom image sizes #14

Closed
justintadlock opened this issue Jun 7, 2024 · 2 comments
Closed

Audit and potentially remove custom image sizes #14

justintadlock opened this issue Jun 7, 2024 · 2 comments
Assignees
Labels
🧪 Enhancement Spinning up new features in the lab. WordPress Issue Whatcha doin' to me WordPress/Gutenberg?

Comments

@justintadlock
Copy link
Contributor

The theme has long needed to register custom image sizes using the standard add_image_size() function. The reason for this was essentially do the job of custom aspect ratios, which are landing in WordPress 6.6.

Unfortunately, the Image block (unlike the Post Featured Image and Cover blocks) does not support aspect ratios when set to wide or full width. There is an open ticket for this, but it won't land in 6.6:

The theme itself likely only needs aspect ratios for Post Featured Image and Cover, so we may be able to do this before shipping alongside 6.6. But it would limit user choice until the above ticket can land in WP.

Additionally, this may be a good time to audit the theme's image sizes now that we have true aspect ratios.

@justintadlock justintadlock added 🧪 Enhancement Spinning up new features in the lab. WordPress Issue Whatcha doin' to me WordPress/Gutenberg? labels Jun 7, 2024
@justintadlock justintadlock self-assigned this Jun 7, 2024
@acwi111
Copy link

acwi111 commented Aug 10, 2024

@justintadlock
Copy link
Contributor Author

This was addressed in ad245fa and e6958ef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 Enhancement Spinning up new features in the lab. WordPress Issue Whatcha doin' to me WordPress/Gutenberg?
Projects
None yet
Development

No branches or pull requests

2 participants