Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style Variations] Reverse colors for Unravel variation #16

Open
justintadlock opened this issue Jun 25, 2024 · 0 comments
Open

[Style Variations] Reverse colors for Unravel variation #16

justintadlock opened this issue Jun 25, 2024 · 0 comments
Assignees
Labels
🐛 Bug I installed this, and now my website is broken.

Comments

@justintadlock
Copy link
Contributor

The Unravel style variation is a dark color, but it reverses the color palette (e.g., primary-50 is dark while primary-950 is light). This reverses the normal palette shade system. This worked well when we only had global/theme style variations. However, it presents a problem with the addition of color style variations:

Because theme style variations can be mixed with any color style variation, this means that color schemes will often not work since they will use the normal color shade system. If we use the same system within Unravel, other color variations will properly use their darker colors.

@justintadlock justintadlock added the 🐛 Bug I installed this, and now my website is broken. label Jun 25, 2024
@justintadlock justintadlock self-assigned this Jun 25, 2024
justintadlock added a commit that referenced this issue Jun 26, 2024
justintadlock added a commit that referenced this issue Jun 26, 2024
Until we have a solid system for handling dark themes, this variation should be experimental.

Note that dark schemes should work well, but this variation is particularly troublesome because it has so many custom aspects. They do not translate well when mixed with custom color variations.

Related: #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug I installed this, and now my website is broken.
Projects
None yet
Development

No branches or pull requests

1 participant