renamed ltc_encoder_set_bufsize and ltc_encoder_get_buffer to more descriptive/consistent names #48
Conversation
| } | ||
|
|
||
| int ltc_encoder_set_buffersize(LTCEncoder *e, double sample_rate, double fps) { | ||
| free (e->buf); |
There was a problem hiding this comment.
Please use tabs for indent, space to align. Prefer to keep whitespace changes separately. It makes it hard to see the actual diff here.
I should probably push the whole thing though clang-format at some point.
There was a problem hiding this comment.
Sorry about that. I have my compiler (Xcode) setup to turn tabs into spaces automatically. Many people don't want tabs in their code. Be aware that filter and volume getters have also been affected by different whitespace formatting. I only realized it when I looked at the code online. Again sorry about that.
Yes, doing a clang-format is a good idea indeed.
There was a problem hiding this comment.
The convention you are following is to indent with one tab = 8 spaces, correct?
|
Looks good in general. I might split this up in two commits when rebasing (NO-OP: whitespace ;; and API-addition/deprecation) |
|
I am not sure what to do from here. Should I send you a new PR with the correct formatting or are you gonna merge this one and then re-format later? |
|
I've manually applied the changes (63542ba), also updated references in the documentation to point to new functions and updated the example-code, too. |
PR for #45