Some methods missing

[jcelerier]

Namely:

• jack_port_connected
• jack_port_get_latency

Can be solved by adding:

#define jack_port_connected                 WJACK_port_connected
#define jack_port_get_latency               WJACK_port_get_latency

and

JPFUN(1, int,            port_connected, (const jack_port_t *p), (p), NULL)
JPFUN(1, jack_nframes_t, port_get_latency, (jack_port_t *p), (p), NULL)

[x42]

jack_port_get_latency is deprecated and also does not work properly with recent jackd and most jack apps that have a latency callback. prefer jack_port_get_latency_range. Is there an application that needs it?

[jcelerier]

it's what's used in portaudio's JACK implementation (https://app.assembla.com/spaces/portaudio/git/source/master/src/hostapi/jack/pa_jack.c#ln598)

[x42]

that code would actually benefit from the new API. portaudio internals do match jack's jack_port_get_latency_range API: min/max and capture/playback can be directly used to set all of
defaultLowOutputLatency, defaultHighOutputLatency , defaultLowInputLatency, defaultHighInputLatency (currently only input latency is set)

Anyway, what's the use-case of using weakjack for pulseaudio's jack-sink?

[jcelerier]

I'm hitting this bug in jack on windows: jackaudio/jack2#275 and wanted to try to update pa_jack.c to use weak_jack.
But actually, just using the JACK api directly from my own code seems to be much easier.

(note: I'm talking about portaudio, not pulseaudio)

[x42]

+1 for using the JACK API directly!