fix: parsing database kind is more permissive #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
force-pushed
the
permissive-db-kind
branch
2 times, most recently
from
fc8948a
to
37b0cff
Compare
robjtede
force-pushed
the
permissive-db-kind
branch
from
37b0cff
to
2178bea
Compare
Comment on lines
+19
to
23
| match () { | ||
| _ if input.eq_ignore_ascii_case("mysql") => Ok(Self::Mysql), | ||
| _ if input.eq_ignore_ascii_case("postgres") => Ok(Self::Postgres), | ||
| _ => Err(Self::Err::default()), | ||
| } |
There was a problem hiding this comment.
I think this fits better with if, else if, else. Any particular reason for match?
There was a problem hiding this comment.
it's my preferred style for this sort of parsing pattern, only needs 1 line added if we add support for sqlite/mssql or whatever
tenuous-guidance
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.