Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with latest Astro & Solid #46

Closed
marvin-j97 opened this issue Jun 29, 2023 · 6 comments
Closed

Does not work with latest Astro & Solid #46

marvin-j97 opened this issue Jun 29, 2023 · 6 comments

Comments

@marvin-j97
Copy link

Reproduction: https://github.com/marvin-j97/solid-1.7-icons

Icon is invisible.
Changing client:load to client:only fixes it.

@marvin-j97
Copy link
Author

Probably related to #41 ?
Maybe #45 as well

@densumesh
Copy link

the svg path seems to be in quotes in the html causing the svg to not render.
image

@x64Bits
Copy link
Owner

x64Bits commented Jul 1, 2023

Hello, I am very aware of the problem that solid-icons are having when used in astro.

I hadn't given an answer because I wanted to reply with the solution, but it's taking me longer to figure out why this is happening, I think it's a problem in the build because in solid you can't just do <svg>{iconSrc.c}< /svg>, I'm concentrating on fixing this, I'll bring news over the weekend, thanks!

@x64Bits
Copy link
Owner

x64Bits commented Jul 5, 2023

Hi everyone, i comment here about it #41 (comment)

@marvin-j97
Copy link
Author

Working for me @x64Bits 👍

@x64Bits
Copy link
Owner

x64Bits commented Jul 5, 2023

Great @marvin-j97! Thank you very much for notifying this and the effort for the code to reproduce the error helped a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants