Breakpoint's Log Text is limited to 256 chars

[Alligator-1]

Feature type

Quality of life, Debugging

Describe the feature

Breakpoint's Log Text is limited to 256 characters, this may not be enough, for example I needed to log the GUID & IID of the CoCreateInstance function, I intended to do it this way:
GUID: {x:4:[esp+4]}-{x:2:[esp+4]+4}-{x:2:[esp+4]+6}-{x:1:[esp+4]+8}{x:1:[esp+4]+9}-{x:1:[esp+4]+10}{x:1:[esp+4]+11}{x:1:[esp+4]+12}{x:1:[esp+4]+13}{x:1:[esp+4]+14}{x:1:[esp+4]+15}, IID: {x:4:[esp+10]}-{x:2:[esp+10]+4}-{x:2:[esp+10]+6}-{x:1:[esp+10]+8}{x:1:[esp+10]+9}-{x:1:[esp+10]+10}{x:1:[esp+10]+11}{x:1:[esp+10]+12}{x:1:[esp+10]+13}{x:1:[esp+10]+14}{x:1:[esp+10]+15}

But all that text didn't fit in the input field.....

Please increase the allowed text length, or remove the restriction altogether

[mrexodia]

If you have some time, it would be appreciated if you could test this PR #3317. It completely overhauls some internal stuff related to breakpoints and one of the benefits is a massively increased limit to ~4kb (eventually it will be "unlimited", but this requires some more work).

[Alligator-1]

Yes, thank you very much!
I downloaded the AppVeyour build (https://ci.appveyor.com/project/mrexodia/x64dbg/builds/49319534/artifacts), and tried inserting a long LogText, but unfortunately it still limited me to 256 characters.

[mrexodia]

This is very strange, thanks for giving it a try. Will try to figure out why that happens...

[Alligator-1]

I think that's what this is about.

x64dbg/src/gui/Src/Gui/EditBreakpointDialog.ui

Line 79 in caa578a

<number>255</number>

☺️

[mrexodia]

LOL, thanks a lot. I was checking all the code for hidden limits, but I had no idea this was a thing. Please try the new build when it finishes (a comment should pop up on the pull request).

[Alligator-1]

Works very well!☺️ Thanks a lot!