Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code folding collapse sometimes doesnt work #829

Open
mrfearless opened this issue Jul 8, 2016 · 4 comments
Open

Code folding collapse sometimes doesnt work #829

mrfearless opened this issue Jul 8, 2016 · 4 comments
Labels
bug The issue describes a bug. It does not mean the bug has been reproduced by a developer. gui The issue is about the GUI of x64dbg.

Comments

@mrfearless
Copy link
Member

Cant reproduce every time, but occasionally when analysing single function, the code fold block doesnt collapse when clicking the - button, just shows the first instruction with ...


@mrexodia
Copy link
Member

mrexodia commented Jul 9, 2016

I think the reason for this is that selection takes priority over function collapsing. I have to look at this more in-depth though, it should fold the function when the selection is only one instruction, but it should fold the selection if it is more than one instruction.

@mrexodia mrexodia added gui The issue is about the GUI of x64dbg. bug The issue describes a bug. It does not mean the bug has been reproduced by a developer. labels Jul 9, 2016
@mrexodia
Copy link
Member

mrexodia commented Jul 9, 2016

@torusrxxx maybe you have some ideas?

@torusrxxx
Copy link
Member

In my opinion, unlike in a IDE, in a disassembler folding a function is not useful. There are just too many functions, so even if you folds all functions, you still cannot view the outline of the program. We are probably not viewing functions being folded for most times.

@ThunderCls
Copy link
Member

This feature is not working at all as for the 11/06/2016 Snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue describes a bug. It does not mean the bug has been reproduced by a developer. gui The issue is about the GUI of x64dbg.
Projects
None yet
Development

No branches or pull requests

4 participants